Asymmetric line flow (Refined); READY FOR REVIEW !!! #789

sambuddhac · 2024-11-13T17:20:34Z

Description

This PR attempts to introduce bidirectional asymmetric transmission lines into the system. Such lines have different values of MW flow limits, loss percentage, and capacity expansion limits along the two directions. While doing so, this PR also ensures that there are also symmetric lines present in the system along with the asymmetric lines and modifies the code in such a way that backwards compatibility is maintained with the existing cases.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Checklist

Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
Code has been tested to ensure all functionality works as intended.
CHANGELOG.md has been updated (if this is a 'notable' change).
I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Post-approval checklist for GenX core developers

After the PR is approved

Check that the latest changes on the target branch are incorporated, either via merge or rebase
Remember to squash and merge if incorporating into develop

src/configure_settings/configure_settings.jl

src/load_inputs/load_network_data.jl

src/write_outputs/transmission/write_nw_expansion.jl

sambuddhac · 2024-12-17T04:03:26Z

Hi @JesseJenkins and @lbonaldo , I have pushed all the modifications to the code base for this PR. Few things to note: First of all, as you will see, it's way more lengthy and complicated than what Jesse suggested to me previously. I first tried with the simpler version. But, was getting bidirectional flows on the asymmetric lines with Qian's example case even when we restricted the flow limits to zero in one of the directions for the asymmetric lines.

With some pondering, I realized that I was doing wrong indexing on the constraints and decision variables. So, I had to do a bit more digging and refining the code. The fundamental reasons for which the code is so much lengthier are: 1) I have both symmetric as well as asymmetric lines in a system and 2) In order to maintain backward compatibility with the existing example cases (As you will observe, I had to go to lengths to split the data-frame into two parts and assign separate variables and constraint names so that things stay clean and correct. I could not find an easier way to do this. I'll highly appreciate any feedback on this).

We tested with @qluo0320github 's example cases and it seems the results are sensible (?) However, I still get discrepancies when I benchmark against an actually symmetric system versus a "simulated" symmetric system (in which the asymmetric lines have the same flow limits, loss percentages, and transmission buildout in both directions). I am attaching hereby all the relevant flow comparison
Flow_Comparisons.xlsx
result file (the names should be self-explanatory) here for you to take a look.

I scrutinized the code several times, but couldn't spot any flaw so far. I would appreciate if you could point some obvious bug (if at all) that I might have missed. Also, I would appreciate taking a look at the quadratic loss formulation. I believe I did it right, but am not totally certain. Thank you so much !!! I have also updated most of the doc pages; I will wrap up parts of the transmission.jl doc page and make another push to close this.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 280 to 282 in 7d90bd9



	if setup["asymmetrical_trans_flow_limit"] ==1

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 289 to 290 in 7d90bd9

    
           cMaxFlow_out_asym[l = 1:L_asym, t = 1:T], vFLOW[(l+L_sym), t] <= EP[:eAvail_Trans_Cap_Pos][l] #Change these with Auxiliary  
        
           cMaxFlow_in_asym[l = 1:L_asym, t = 1:T], vFLOW[(l+L_sym), t] >= -EP[:eAvail_Trans_Cap_Neg][l] #Change these with Auxiliary

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 294 to 297 in 7d90bd9

    
           begin 
        
               cMaxFlow_out[l = 1:L, t = 1:T], vFLOW[l, t] <= EP[:eAvail_Trans_Cap][l] 
        
               cMaxFlow_in[l = 1:L, t = 1:T], vFLOW[l, t] >= -EP[:eAvail_Trans_Cap][l] 
        
           end)

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 299 in 7d90bd9

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 302 in 7d90bd9

if setup["asymmetrical_trans_flow_limit"] ==1

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 323 in 7d90bd9

    
           inputs["pPercent_Loss_Pos"][l] * (vTAUX_POS_ASYM[l, t]) + inputs["pPercent_Loss_Neg"][l] * (vTAUX_NEG_ASYM[l, t])

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 327 in 7d90bd9

vTAUX_POS_ASYM[l, t] - vTAUX_NEG_ASYM[l, t] == vFLOW[(l+L_sym), t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 331 in 7d90bd9

    
           vTAUX_POS_ASYM[l, t] + vTAUX_NEG_ASYM[l, t] <= min(EP[:eAvail_Trans_Cap_Pos][l], EP[:eAvail_Trans_Cap_Neg][l])

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 343 in 7d90bd9

vTAUX_NEG[l, t] <= EP[:eAvail_Trans_Cap][l] - vPROD_TRANSCAP_ON[l, t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 370 in 7d90bd9

    
           vTAUX_NEG_ASYM[l, t] <= EP[:eAvail_Trans_Cap_Neg][l] - vPROD_TRANSCAP_ON_NEG_ASYM[l, t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 377 in 7d90bd9

    
           vTAUX_POS_ASYM[l, t] <= EP[:eAvail_Trans_Cap_Pos][l] - vPROD_TRANSCAP_ON_POS_ASYM[l, t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 401 in 7d90bd9

(1 - vTAUX_POS_ON_POS_ASYM[l, t]) * inputs["pTrans_Max_Possible_Pos"][l]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 406 in 7d90bd9

(1 - vTAUX_POS_ON_NEG_ASYM[l, t]) * inputs["pTrans_Max_Possible_Neg"][l]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 435 in 7d90bd9

vTAUX_NEG[l, t] <= EP[:eAvail_Trans_Cap][l] - vPROD_TRANSCAP_ON[l, t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 459 in 7d90bd9

if setup["asymmetrical_trans_flow_limit"] ==1

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 470 to 471 in 7d90bd9

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS)) +

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 473 to 474 in 7d90bd9

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS)))

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 480 in 7d90bd9

sum(vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_POS[l, 0, t] ==

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 483 in 7d90bd9

sum(vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_NEG[l, 0, t] ==

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 511 in 7d90bd9

cTAuxOrderPos2[l in LOSS_LINES_SYM, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 515 in 7d90bd9

cTAuxOrderNeg2[l in LOSS_LINES_SYM, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 548 to 549 in 7d90bd9

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible_Pos"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_POS_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS)) +

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 551 to 552 in 7d90bd9

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible_Neg"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_NEG_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS)))

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 558 to 559 in 7d90bd9

    
           sum(vTAUX_POS_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_POS_ASYM[l, 0, t] == 
        
           vFLOW[(l+L_sym), t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 561 to 562 in 7d90bd9

    
           sum(vTAUX_NEG_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_NEG_ASYM[l, 0, t] == 
        
           -vFLOW[(l+L_sym), t]

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 571 in 7d90bd9

cTAuxMaxNeg_asym[l in LOSS_LINES_ASYM, s = 1:TRANS_LOSS_SEGS, t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 581 in 7d90bd9

cTAuxOrderPos1_asym[l in LOSS_LINES_ASYM, s = 1:TRANS_LOSS_SEGS, t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 585 in 7d90bd9

cTAuxOrderNeg1_asym[l in LOSS_LINES_ASYM, s = 1:TRANS_LOSS_SEGS, t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 589 in 7d90bd9

    
           cTAuxOrderPos2_asym[l in LOSS_LINES_ASYM, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 593 in 7d90bd9

    
           cTAuxOrderNeg2_asym[l in LOSS_LINES_ASYM, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 606 in 7d90bd9

inputs["pTrans_Max_Possible_Pos"][l] * (1 - vTAUX_POS_ON_ASYM[l, 1, t])

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 612 in 7d90bd9

inputs["pTrans_Max_Possible_Neg"][l] * (1 - vTAUX_NEG_ON_ASYM[l, 1, t])

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 625 to 626 in 7d90bd9

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS)) +

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 628 to 629 in 7d90bd9

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS)))

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 635 in 7d90bd9

sum(vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_POS[l, 0, t] ==

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 638 in 7d90bd9

sum(vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_NEG[l, 0, t] ==

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 666 in 7d90bd9

cTAuxOrderPos2[l in LOSS_LINES, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 670 in 7d90bd9

cTAuxOrderNeg2[l in LOSS_LINES, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

src/load_inputs/load_network_data.jl

src/model/core/transmission/investment_transmission.jl

src/model/core/transmission/transmission.jl

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

JuliaFormatter

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 596 in 146916a

    
           cTAuxOrderNeg2_asym[l in LOSS_LINES_ASYM, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 609 in 146916a

inputs["pTrans_Max_Possible_Pos"][l] * (1 - vTAUX_POS_ON_ASYM[l, 1, t])

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 615 in 146916a

inputs["pTrans_Max_Possible_Neg"][l] * (1 - vTAUX_NEG_ON_ASYM[l, 1, t])

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 628 to 629 in 146916a

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS)) +

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Lines 631 to 632 in 146916a

    
           sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) * 
        
               vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS)))

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 638 in 146916a

sum(vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_POS[l, 0, t] ==

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 641 in 146916a

sum(vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_NEG[l, 0, t] ==

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 669 in 146916a

cTAuxOrderPos2[l in LOSS_LINES, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

[JuliaFormatter] _{reported by reviewdog 🐶}

GenX.jl/src/model/core/transmission/transmission.jl

Line 673 in 146916a

cTAuxOrderNeg2[l in LOSS_LINES, s = 1:(TRANS_LOSS_SEGS - 1), t = 1:T],

src/model/core/transmission/transmission.jl

… asymmetrical flows

…olumns for bidirectional asymmetric flow

…refined write_expansion

… lines

lbonaldo · 2025-01-17T15:45:06Z

CHANGELOG.md

+- Modified `transmission.jl`, `investment_transmission.jl`, `load_network_data.jl`, 
+`write_transmission_flows.jl`, `write_transmision_losses.jl`, and `write_network_expansion.jl`
+for implementing asymmetric bidirectional flows. (#789)


This part should go under the ##Unreleased section above as it belongs to a new release.

lbonaldo · 2025-01-17T15:45:52Z

example_systems/1_three_zones_asymmetric_bidirectional/README.md

@@ -0,0 +1,32 @@
+# Three Zones


If we decide to keep this example, we might need to this description.

lbonaldo · 2025-01-17T15:49:57Z

example_systems/1_three_zones_asymmetric_bidirectional/settings/genx_settings.yml

+UCommit: 2 # Unit committment of thermal power plants; 0 = not active; 1 = active using integer clestering; 2 = active using linearized clustering
+TimeDomainReduction: 1 # Time domain reduce (i.e. cluster) inputs based on Demand_data.csv, Generators_variability.csv, and Fuels_data.csv; 0 = not active (use input data as provided); 0 = active (cluster input data, or use data that has already been clustered)
+OutputFullTimeSeries: 1
+asymmetrical_trans_flow_limit: 1 # Switch to indicate if asymmetrical bidirectional lines are included in the system or not


By convention, we use PascalCase (or UpperCamelCase) for setting keys: AsymmetricalTransFlowLimit.

lbonaldo · 2025-01-17T15:51:28Z

example_systems/1_three_zones_asymmetric_bidirectional/system/Network.csv

+ME,z3,4,1,2,1,2000,4000,MA_to_CT,123.0584,0.012305837,0.12305837,1206,2412,12075,0.95,0,0
+,,5,1,3,1,1000,800,MA_to_ME,196.5385,0.019653847,0.19653847,1926,963,19200,0.95,0,0
+,,6,2,3,1,500,1200,CT_to_ME,196.5385,0.019653847,0.19653847,1206,603,12000,0.95,0,0


I believe the Network_Lines column should be [1, 2, 3, 4, 5] here. I'm getting an error when trying to run this case.

lbonaldo · 2025-01-17T15:53:16Z

...tems/6_three_zones_w_multistage_asymmetric_bidirectional/inputs/inputs_p3/system/Network.csv

I'm encountering the following error message when trying to run this example:

Reading Input CSV Files ERROR: ArgumentError: column name :Asymmetrical not found in the data frame

lbonaldo · 2025-01-17T15:54:24Z

src/configure_settings/configure_settings.jl

@@ -37,7 +37,9 @@ function default_settings()
        "ResourcePoliciesFolder" => "policy_assignments",
        "SystemFolder" => "system",
        "PoliciesFolder" => "policies",
-        "ObjScale" => 1)
+        "ObjScale" => 1,
+        "asymmetrical_trans_flow_limit" => 0


Same as above, we typically use PascalCase (or UpperCamelCase) for setting keys.

lbonaldo · 2025-01-17T16:00:20Z

src/load_inputs/load_network_data.jl

+    if setup["asymmetrical_trans_flow_limit"] == 1
+        L_asym = length(filtered_vector(network_var, :Asymmetrical, 1, :Network_Lines)) #Number of asymmetrical lines
+    end


This line will throw an error if ["asymmetrical_trans_flow_limit"] == 1 but the :Asymmetrical column is not found in the Network.csv file. We could add a validation to ensure that:

If the user sets ["asymmetrical_trans_flow_limit"] == 1

Then a corresponding set of additional columns must be provided.

lbonaldo · 2025-01-17T16:11:20Z

src/write_outputs/transmission/write_nw_expansion.jl

+    for i in EXPANSION_LINES_ASYM
+        transcap_pos[i] = value.(EP[:vNEW_TRANS_CAP_Pos][i])
+        transcap_neg[i] = value.(EP[:vNEW_TRANS_CAP_Neg][i])    


Suggested change

for i in EXPANSION_LINES_ASYM

transcap_pos[i] = value.(EP[:vNEW_TRANS_CAP_Pos][i])

transcap_neg[i] = value.(EP[:vNEW_TRANS_CAP_Neg][i])

for i in eachindex(EXPANSION_LINES_ASYM)

asym_line_index = EXPANSION_LINES_ASYM[i]

transcap_pos[i] = value.(EP[:vNEW_TRANS_CAP_Pos][asym_line_index])

transcap_neg[i] = value.(EP[:vNEW_TRANS_CAP_Neg][asym_line_index])

lbonaldo · 2025-01-17T16:14:58Z

src/write_outputs/write_outputs.jl

@@ -122,14 +122,14 @@ function write_outputs(EP::Model, path::AbstractString, setup::Dict, inputs::Dic
            println(elapsed_time_flows)
        end

-        if output_settings_d["WriteTransmissionLosses"]
+        #=if output_settings_d["WriteTransmissionLosses"]


Can we uncomment this part?

lbonaldo

First round of review. Thanks @sambuddhac for this PR. In your opinion, which example case should we keep? The branch is now rebased with the latest develop.

lbonaldo · 2025-01-17T16:40:18Z

src/write_outputs/transmission/write_nw_expansion.jl

+    L_sym = inputs["L_sym"]
+    L_asym = inputs["L_asym"] #Number of transmission lines with different capacities in two directions


L_sym doesn't seem to be used

lbonaldo · 2025-01-17T16:42:36Z

src/model/core/transmission/transmission.jl

+    L_sym = inputs["L_sym"] # Number of transmission lines with symmetrical bidirectional flow
+    L_asym = inputs["L_asym"] #Number of transmission lines with different capacities in two directions


These two variables do not seem to be used.

lbonaldo · 2025-01-17T16:44:02Z

src/model/core/transmission/transmission.jl

+    SYMMETRIC_LINE_INDEX = inputs["symmetric_line_index"]
+    ASYMMETRIC_LINE_INDEX = inputs["asymmetric_line_index"]


It seems that the convention for inputs keys is to use capitalized words separated by underscores. What do you think about applying this convention to these two keys as well?

lbonaldo · 2025-01-17T16:59:37Z

src/load_inputs/load_network_data.jl


+    if setup["asymmetrical_trans_flow_limit"] == 1
+        # Transmission capacity of the network for asymmetrical lines; return direction(in MW)
+        inputs_nw["pTrans_Max_Possible_Neg"] = inputs_nw["pTrans_Max_Neg"] = to_floats(:Line_Max_Flow_MW_Neg) / scale_factor  # convert to GW


Another small suggestion: we usually place the units at the end of the key, e.g., Inv_Cost_Per_MWyr, Line_Max_Flow_MW, etc

lbonaldo · 2025-01-17T19:22:52Z

src/model/core/transmission/investment_transmission.jl

+    L_sym = inputs["L_sym"]
+    L_asym = inputs["L_asym"] #Number of transmission lines with different capacities in two directions
+    L = inputs["L"]


These three variables do not seem to be used.

lbonaldo · 2025-01-17T20:25:19Z

src/load_inputs/load_network_data.jl


    if setup["NetworkExpansion"] == 1
        # Network lines and zones that are expandable have non-negative maximum reinforcement inputs
-        inputs_nw["EXPANSION_LINES"] = findall(inputs_nw["pMax_Line_Reinforcement"] .>= 0)
-        inputs_nw["NO_EXPANSION_LINES"] = findall(inputs_nw["pMax_Line_Reinforcement"] .< 0)
+        inputs_nw["EXPANSION_LINES"] = findall(inputs_nw["pMax_Line_Reinforcement"] .> 0)


I think we could do the intersection with SYMMETRIC_LINE_INDEX here to avoid needing to do it throughout the rest of the code.

lbonaldo · 2025-01-17T20:25:58Z

src/load_inputs/load_network_data.jl

+                                                                                                #scale_factor # Convert to GW
+            inputs_nw["pLine_Max_Flow_Possible_MW_Neg"] = to_floats(:Line_Max_Flow_Possible_MW_Neg) /
+                                                                                                scale_factor # Convert to GW
+        end
    end

    ## Sets and indices for transmission losses and expansion
    inputs_nw["TRANS_LOSS_SEGS"] = setup["Trans_Loss_Segments"] # Number of segments used in piecewise linear approximations quadratic loss functions
    inputs_nw["LOSS_LINES"] = findall(inputs_nw["pTrans_Loss_Coef"] .!= 0) # Lines for which loss coefficients apply (are non-zero);


Same as below, we could do the intersection with SYMMETRIC_LINE_INDEX here instead of throughout the rest of the code.

lbonaldo · 2025-01-17T22:05:38Z

src/model/core/transmission/transmission.jl

+    if NetworkExpansion == 1
+        # Network lines and zones that are expandable have non-negative maximum reinforcement inputs
+        EXPANSION_LINES = inputs["EXPANSION_LINES"]
+        EXPANSION_LINES_ASYM = inputs["EXPANSION_LINES_ASYM"]


These two variables do not seem to be used.

sambuddhac mentioned this pull request Nov 13, 2024

Update transmission.jl to account for asymmetrical directional flow l… #769

Closed

12 tasks

github-actions bot reviewed Nov 22, 2024

View reviewed changes

src/configure_settings/configure_settings.jl Show resolved Hide resolved

github-actions bot reviewed Dec 3, 2024

View reviewed changes

src/load_inputs/load_network_data.jl Show resolved Hide resolved

lbonaldo added the enhancement New feature or request label Dec 3, 2024

lbonaldo force-pushed the asymmetric_line_flow branch from 0002caf to 0e224c5 Compare December 3, 2024 23:31

lbonaldo added this to the v0.4.2 milestone Dec 4, 2024

github-actions bot reviewed Dec 4, 2024

View reviewed changes

src/write_outputs/transmission/write_nw_expansion.jl Outdated Show resolved Hide resolved

sambuddhac changed the title ~~Asymmetric line flow (Refined) #Work in Progress; DO NOT MERGE YET !!!~~ Asymmetric line flow (Refined) #Work in Progress; READY FOR REVIEW !!! Dec 17, 2024

sambuddhac requested review from JesseJenkins and lbonaldo December 17, 2024 03:05

sambuddhac assigned JesseJenkins Dec 17, 2024

sambuddhac marked this pull request as ready for review December 17, 2024 15:02

sambuddhac changed the title ~~Asymmetric line flow (Refined) #Work in Progress; READY FOR REVIEW !!!~~ Asymmetric line flow (Refined); READY FOR REVIEW !!! Dec 18, 2024

github-actions bot reviewed Dec 18, 2024

View reviewed changes

GenXProject modified the milestones: v0.4.2, v0.4.3 Jan 16, 2025

sambuddhac added 12 commits January 17, 2025 09:59

Refined Asymmetric Bidirectional Flow

7e0d452

Modified the line flow limits with asymmetric bidirectional flow limits

f4502aa

Updated files for investment_transmission and load_network

32acbab

Update transmission.jl

5a04491

Modified the transmission write output files to reflect bidirectional…

73320c7

… asymmetrical flows

Modified load_network_data.jl and Network.csv to include additional c…

8f5d2ba

…olumns for bidirectional asymmetric flow

Got rid of unnecessary poitive nd negative reinforcement cost

04bf9dc

Corrected the cost term for bidirectional investment

0f20fc0

Refined asymmetric flows; Debugging

7c39d3b

Write output files and doc pages for investment transmission updated

f9ea370

Added new example case with zero capacities in forward direction and …

4d04015

…refined write_expansion

Added new example case

753d680

sambuddhac added 8 commits January 17, 2025 10:02

precompile bug fixed

6a088ff

Corrected and refined quadratic loss reformulation

47e7bf6

Doc update and fixed absolute value of flow constraint for asymmetric…

f30e28c

… lines

Write output files and doc pages for investment transmission updated

263c632

Modified CHANGELOG

a2be273

Merge conflict bug fix

3dab623

Fixed absolute value of flow RHS constraint by imposing tighter bounds

d219590

Corrected indexing

6fc5330

lbonaldo force-pushed the asymmetric_line_flow branch from 1d3943a to 6fc5330 Compare January 17, 2025 15:11

lbonaldo reviewed Jan 17, 2025

View reviewed changes

lbonaldo requested changes Jan 17, 2025

View reviewed changes

lbonaldo reviewed Jan 17, 2025

View reviewed changes

Repository owner deleted a comment from github-actions bot Jan 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Asymmetric line flow (Refined); READY FOR REVIEW !!! #789

Asymmetric line flow (Refined); READY FOR REVIEW !!! #789

sambuddhac commented Nov 13, 2024 •

edited

Loading

sambuddhac commented Dec 17, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

lbonaldo left a comment •

edited

Loading

lbonaldo Jan 17, 2025 •

edited by GenXProject

Loading

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

lbonaldo Jan 17, 2025

	cMaxFlow_out_asym[l = 1:L_asym, t = 1:T], vFLOW[(l+L_sym), t] <= EP[:eAvail_Trans_Cap_Pos][l] #Change these with Auxiliary
	cMaxFlow_in_asym[l = 1:L_asym, t = 1:T], vFLOW[(l+L_sym), t] >= -EP[:eAvail_Trans_Cap_Neg][l] #Change these with Auxiliary

	begin
	cMaxFlow_out[l = 1:L, t = 1:T], vFLOW[l, t] <= EP[:eAvail_Trans_Cap][l]
	cMaxFlow_in[l = 1:L, t = 1:T], vFLOW[l, t] >= -EP[:eAvail_Trans_Cap][l]
	end)

	sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) *
	vTAUX_POS[l, s, t] for s in 1:TRANS_LOSS_SEGS)) +

	sum((2 * s - 1) * (inputs["pTrans_Max_Possible"][l] / TRANS_LOSS_SEGS) *
	vTAUX_NEG[l, s, t] for s in 1:TRANS_LOSS_SEGS)))

	sum((2 * s - 1) * (inputs["pTrans_Max_Possible_Pos"][l] / TRANS_LOSS_SEGS) *
	vTAUX_POS_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS)) +

	sum((2 * s - 1) * (inputs["pTrans_Max_Possible_Neg"][l] / TRANS_LOSS_SEGS) *
	vTAUX_NEG_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS)))

	sum(vTAUX_POS_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_POS_ASYM[l, 0, t] ==
	vFLOW[(l+L_sym), t]

	sum(vTAUX_NEG_ASYM[l, s, t] for s in 1:TRANS_LOSS_SEGS) - vTAUX_NEG_ASYM[l, 0, t] ==
	-vFLOW[(l+L_sym), t]

-    for i in EXPANSION_LINES_ASYM
-        transcap_pos[i] = value.(EP[:vNEW_TRANS_CAP_Pos][i])
-        transcap_neg[i] = value.(EP[:vNEW_TRANS_CAP_Neg][i])
+   for i in eachindex(EXPANSION_LINES_ASYM)
+        asym_line_index = EXPANSION_LINES_ASYM[i]
+        transcap_pos[i] = value.(EP[:vNEW_TRANS_CAP_Pos][asym_line_index])
+        transcap_neg[i] = value.(EP[:vNEW_TRANS_CAP_Neg][asym_line_index])

		L_sym = inputs["L_sym"]
		L_asym = inputs["L_asym"] #Number of transmission lines with different capacities in two directions

		L_sym = inputs["L_sym"] # Number of transmission lines with symmetrical bidirectional flow
		L_asym = inputs["L_asym"] #Number of transmission lines with different capacities in two directions

		SYMMETRIC_LINE_INDEX = inputs["symmetric_line_index"]
		ASYMMETRIC_LINE_INDEX = inputs["asymmetric_line_index"]

Asymmetric line flow (Refined); READY FOR REVIEW !!! #789

Are you sure you want to change the base?

Asymmetric line flow (Refined); READY FOR REVIEW !!! #789

Conversation

sambuddhac commented Nov 13, 2024 • edited Loading

Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

Checklist

How this can be tested

Post-approval checklist for GenX core developers

sambuddhac commented Dec 17, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lbonaldo left a comment • edited Loading

Choose a reason for hiding this comment

lbonaldo Jan 17, 2025 • edited by GenXProject Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sambuddhac commented Nov 13, 2024 •

edited

Loading

sambuddhac commented Dec 17, 2024 •

edited

Loading

lbonaldo left a comment •

edited

Loading

lbonaldo Jan 17, 2025 •

edited by GenXProject

Loading